Skip to content

Conversation

ZNeumann
Copy link
Contributor

@ZNeumann ZNeumann commented Sep 9, 2025

No description provided.

zsistla and others added 7 commits August 12, 2025 15:06
When agent is not recording, Observer API fcall_init callback shouldn't
do anything, including framework detection. This is how the agent
operated before it used Observer API to hook into Zend Engine.
…handlers (#1113)

Our instrumentation of framework exception handlers can result in
excess, unwanted error events being generated. Sometimes, these events
are plentiful and diverse enough that manual filtering through them with
our other error related INI options is too much effort. In cases like
that, this setting exists as an easy solution. Errors may still appear
on spans, but error events will, in general, not be created. This works
especially well when the customer inserts their own error handling logic
into the stack, so that they are able to call our API for certain,
specific errors that they wish to be error events.
#1104)

This implements the sampling spec to allow control over the agent
sampling decisions based on the value in the sampled flag of an inbound
traceparent header.

---------

Co-authored-by: Michal Nowacki <[email protected]>
…on(true) (#1072)

Some transaction globals were leaked when calling
`newrelic_end_transaction(true)`. The freeing of these transaction
globals has been moved to join all the other transaction globals to
alleviate this.

In so doing, additional rshutdown methods are needed. This is because
the transaction globals contain reference incremented zvals. If we wait
until postdeactivate, those zvals will be in an undefined state and the
data structures containing those references cannot be properly freed. In
line with other transaction globals, we trigger a shutdown method during
rshutdown to free these globals while the zvals are still valid.
Co-authored-by: Michal Nowacki <[email protected]> who added go version check and go autoupdate.
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Sep 9, 2025

Test Suite Status Result
Multiverse 15/16 passing
SOAK 83/85 passing

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 83.54430% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (2f79c48) to head (04c44e4).

Files with missing lines Patch % Lines
agent/fw_laravel.c 0.00% 6 Missing ⚠️
agent/fw_lumen.c 0.00% 3 Missing ⚠️
agent/php_nrini.c 91.66% 2 Missing ⚠️
axiom/nr_distributed_trace.c 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   78.12%   78.15%   +0.03%     
==========================================
  Files         193      193              
  Lines       27989    28053      +64     
==========================================
+ Hits        21866    21925      +59     
- Misses       6123     6128       +5     
Flag Coverage Δ
agent-for-php-7.2 78.40% <84.21%> (+0.03%) ⬆️
agent-for-php-7.3 78.42% <84.21%> (+0.03%) ⬆️
agent-for-php-7.4 78.28% <84.21%> (+0.03%) ⬆️
agent-for-php-8.0 77.48% <84.21%> (+0.02%) ⬆️
agent-for-php-8.1 77.79% <84.21%> (+0.02%) ⬆️
agent-for-php-8.2 77.41% <84.21%> (+0.03%) ⬆️
agent-for-php-8.3 77.41% <84.21%> (+0.03%) ⬆️
agent-for-php-8.4 77.43% <84.21%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZNeumann ZNeumann merged commit 1e5fa6d into main Sep 9, 2025
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants